Pull Request Test Coverage Report for Build 17260823135

Details

• 24 of 32 (75.0%) changed or added relevant lines in 3 files are covered.
• 9 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.02%) to 54.744%

Totals
Change from base Build 17259383467:	-0.02%
Covered Lines:	6203
Relevant Lines:	11331

💛 - Coveralls

@avallete I have a supabase project that can reproduce the timeout. How can I share it with you privately?

Hey ! Thank's for reaching out ! Yes I have. This allowed us to pinpoint that the cause of the issue was a bug in the introspection queries performed that postgres-meta, those only filter by schema/entity at the end of the query, constructing the CTE for all of the objects, before filtering out only the ones it needs.

I drafted a PR to adress this: supabase/postgres-meta#980

Which on my tests reduce typegen time from 22s+ to ~200ms. We'll try to roll that out ASAP.

Awesome! Yes this matches what we observed on our end. The more schemas we have the longer the generation takes even when we apply the schema filters. Look forward to the release.

Hey @yilinjuang

Just a quick update that the new version of postgres-meta has been released and should help with the typegen issue. It's not been released as the new default into the cli yet but you can try it early on by running:

echo "v0.91.6" > supabase/.temp/pgmeta-version

Before running your local stack, this should fix your local postgres-meta version to the one containing the fix. You should then be able to generate your types with:

npx supabase gen types --lang typescript --local  > database.generated.ts

Would love to hear if it solve your use case or any feedbacks.

@avallete thanks it works! It now takes 15 seconds to generate. It used to be 10 times.

But I got another problem, using the latest cli v2.40.4 or v2.40.6, I cannot start supabase locally. Health check of postgrest failed. I filed another issue.